Skip to content

chore(dogfood): make devcontainer.json to build dogfood Dockerfile #13567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 13, 2024
Merged

chore(dogfood): make devcontainer.json to build dogfood Dockerfile #13567

merged 3 commits into from
Jun 13, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jun 13, 2024 •
edited
Loading

Our existing devcontainer.json references the pre-built image.

@johnstcn johnstcn requested a review from mtojek June 13, 2024 12:53
@johnstcn johnstcn self-assigned this Jun 13, 2024
@johnstcn johnstcn changed the title dogfood: make devcontainer.json to build dogfood Dockerfile chore(dogfood): make devcontainer.json to build dogfood Dockerfile Jun 13, 2024
mtojek
mtojek approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johnstcn johnstcn merged commit 5d3f3c0 into main Jun 13, 2024
33 checks passed
@johnstcn johnstcn deleted the cj/dogfood-devcontainer branch June 13, 2024 13:31
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @mtojek