-
Notifications
You must be signed in to change notification settings - Fork 881
fix: fix workspace actions options #13572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is an improvement but I'm not sure if our tests are in place to avoid confusion and unwanted changes in the future.
I think there should be a story for every code path now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. I left two comments in Storybook for your consideration.
Simplify the code a bit to prevent bad states, and add additional stories.