chore: refactor apphealth and tests to use clock testing library #13576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikecurtis and the rest of your teammates on |
spikecurtis
commented
Jun 14, 2024
| for i := 0; i < 2; i++ { | ||
| c := healthcheckTrap.MustWait(ctx) | ||
| c.Release() | ||
| healthchecksStarted[i] = c.Tags[1] |
There was a problem hiding this comment.
nicely illustrates a use case for multiple tags
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the apphealth subsystem and unit tests to use
clock.Clock.Also slightly simplifies the implementation, which wrapped a function that never returned an error in a
retry.Retry. The retry is entirely superfluous in that case, so removed.UTs used to take a few seconds to run, and now run in milliseconds or better. No sleeps,
Eventually, or polling.Dropped the "no spamming" test since we can directly assert the number of handler calls on the mainline test case.