chore: add organization member api + cli #13577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68a5b2b to
a4a986d
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
47b1864 to
bf3bfd0
Compare
* docs: add screenshots page * fmt
e488414 to
909a7ce
Compare
f0ssel
approved these changes
Jun 18, 2024
| r.Use( | ||
| // Adding a member requires "read" permission | ||
| // on the site user. So limited to owners and user-admins. | ||
| // TODO: Allow org-admins to add users via some new permission? Or give them |
There was a problem hiding this comment.
For a future PR: I think a new permission would be nice here, I don't think it's intuitive for developers to know that a read permission on a site user grants them access to add new org members.
There was a problem hiding this comment.
@f0ssel one option is just to not require the read permission to add a user, using the system context to fetch a user.
I agree it is not intuitive at present. Since orgs are still a ways out, I'm not spending too much time on these details atm.
| func TestAddMember(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| t.Run("OK", func(t *testing.T) { |
There was a problem hiding this comment.
I think testing to error cases like missing user and org 404, etc for posterity could be good as well
909a7ce to
ce367e5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coder organization members add <username | user_id>