Skip to content

fix: write server config to telemetry #13590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 18, 2024
Merged

fix: write server config to telemetry #13590

merged 4 commits into from
Jun 18, 2024

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Jun 17, 2024

Git auth configs regressed in fefacc5 :/

Instead of needing to constantly add new options, it's better if we send the entire config as a blob.

@kylecarbs kylecarbs requested review from coadler and ammario June 17, 2024 17:20
@kylecarbs kylecarbs self-assigned this Jun 17, 2024
@coadler
Copy link
Contributor

coadler commented Jun 17, 2024

Was so confused what that was

@kylecarbs
Copy link
Member Author

Yeah, it's also not named properly anymore, so will fix that too when I land (presently airborne)

@kylecarbs kylecarbs changed the title fix: add external auth configs to telemetry fix: write server config to telemetry Jun 18, 2024
@kylecarbs kylecarbs merged commit 3a1fa04 into main Jun 18, 2024
34 of 37 checks passed
@kylecarbs kylecarbs deleted the extauthtelemetry branch June 18, 2024 20:20
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants