Skip to content

fix: don't allow "new" or "create" as url-friendly names #13596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 18, 2024
Merged

fix: don't allow "new" or "create" as url-friendly names #13596

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d8f959a
fix: don't allow "new" or "create" as url-friendly names
aslilac Jun 18, 2024
26512ff
🧹
aslilac Jun 18, 2024
cad19a5
`make gen`
aslilac Jun 18, 2024
8f11aed
fix a bunch of test names
aslilac Jun 18, 2024
a0014d3
add a lil comment
aslilac Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
🧹
  • Loading branch information
@aslilac
aslilac committed Jun 18, 2024
commit 26512ff71e8ed491551de619f860e41fc7d6938d
4 changes: 2 additions & 2 deletions codersdk/groups.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ type CreateGroupRequest struct {

type Group struct {
ID uuid.UUID `json:"id" format:"uuid"`
Name string `json:"name" validate:"required,group_name"`
DisplayName string `json:"display_name" validate:"required,group_display_name"`
Name string `json:"name"`
DisplayName string `json:"display_name"`
OrganizationID uuid.UUID `json:"organization_id" format:"uuid"`
Members []ReducedUser `json:"members"`
AvatarURL string `json:"avatar_url"`
Expand Down
Loading