Skip to content

feat: unify organization and deployment management settings #13602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jul 1, 2024
Merged

feat: unify organization and deployment management settings #13602

merged 17 commits into from
Jul 1, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Jun 18, 2024 •
edited
Loading

Screenshot 2024-06-20 at 3 20 07 PM

Improves the organization settings, and brings in the deployment settings to the same view with a shared sidebar for navigation.

@aslilac aslilac changed the title draft: management settings feat: unified organization and deployment management settings Jun 20, 2024
@aslilac aslilac changed the title feat: unified organization and deployment management settings feat: unify organization and deployment management settings Jun 20, 2024
@aslilac aslilac marked this pull request as ready for review June 20, 2024 20:50
@aslilac aslilac requested a review from BrunoQuaresma June 20, 2024 20:50
BrunoQuaresma
BrunoQuaresma reviewed Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments related to the code and about tests, since this is an important feature, I would add e2e tests to cover the critical flows:

  • Create a new org
  • Update a org
  • Delete a org

@BrunoQuaresma

This comment was marked as resolved.

Sign in to view
@aslilac
Copy link
Member Author

aslilac commented Jun 24, 2024

When trying to create an org with an existent name the error is displayed in the top when IMO it should be displayed in the form.

We can adjust that, but that's a backend problem.

@aslilac
Copy link
Member Author

aslilac commented Jun 28, 2024

Left a few comments related to the code and about tests, since this is an important feature, I would add e2e tests to cover the critical flows

It's behind an experiment, so I can't yet. 😅

@aslilac aslilac requested a review from BrunoQuaresma June 28, 2024 20:21
@aslilac
Copy link
Member Author

aslilac commented Jun 28, 2024

actually I guess I can just add it to the env variable in the e2e test config

@aslilac aslilac merged commit d977654 into main Jul 1, 2024
29 checks passed
@aslilac aslilac deleted the management-settings branch July 1, 2024 17:15
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aslilac @BrunoQuaresma