Skip to content

chore: upgrade Go version to 1.22.4 #13623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 24, 2024
Merged

chore: upgrade Go version to 1.22.4 #13623

merged 7 commits into from
Jun 24, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jun 21, 2024

Note: nix flake is failing to update (maybe due to go 1.22.4 not being in nix pkgs at time of writing?) EDIT: fixed, I just don't know how to nix.

@johnstcn johnstcn marked this pull request as ready for review June 24, 2024 08:38
@matifali
Copy link
Member

matifali commented Jun 24, 2024

Some missing places:

  1. go-version: 1.21.9
    This was running fmt check with go 1.21, we should perhaps use the common setup-go action and enable caching again. It should make little difference.

@matifali
Copy link
Member

Note: nix flake is failing to update (maybe due to go 1.22.4 not being in nix pkgs at time of writing?)

go 1.22.4 should be available. NixOS/nixpkgs#317326

@johnstcn
Copy link
Member Author

Note: nix flake is failing to update (maybe due to go 1.22.4 not being in nix pkgs at time of writing?)

go 1.22.4 should be available. NixOS/nixpkgs#317326

It still shows up as the older version for me here: https://search.nixos.org/packages?channel=unstable&show=go&from=0&size=50&sort=relevance&type=packages&query=go

I figure it's just a matter of time though.

@matifali
Copy link
Member

matifali commented Jun 24, 2024

May be we need to run nix flake update to get the new version.

johnstcn and others added 2 commits June 24, 2024 13:59
I ran it on my amd64 desktop in a WSL shell on Widows 11.
@matifali
Copy link
Member

@johnstcn I ran the ./scripts/update-flake.sh on an amd64 desktop, and now the hash matches.

@johnstcn johnstcn changed the title chore: update Go version to 1.22.4 chore: upgrade Go version to 1.22.4 Jun 24, 2024
@johnstcn johnstcn requested review from coadler and deansheather June 24, 2024 14:12
@johnstcn johnstcn merged commit b4a5c7f into main Jun 24, 2024
38 checks passed
@johnstcn johnstcn deleted the cj/go1.22.4 branch June 24, 2024 14:50
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants