fix: remove connected button #13625
Merged
fix: remove connected button #13625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It didn't make a lot of sense in current form. It will when we improve autostop.
f0ssel
approved these changes
Jun 21, 2024
|
This part of the code has been quite fragile, and I'm wondering if we should have added tests to ensure the correct behavior before merging it. |
|
Since this is just removing I'm less concerned about that. We can manually test on dev before release. |
|
My concern is more about future changes and making sure our future selves remember what the correct behavior should be. |
|
I'm being extra cautious here because we've already introduced a good number of bugs in this component with just simple changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It didn't make a lot of sense in current form. It will when we improve autostop.