chore: switch ssh session stats based on experiment #13637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
johnstcn
reviewed
Jun 24, 2024
This was referenced Jun 24, 2024
johnstcn
approved these changes
Jun 24, 2024
| @@ -1076,5 +1081,5 @@ func getUsageAppName(usageApp string) codersdk.UsageAppName { | |||
| return codersdk.UsageAppName(usageApp) | |||
| } | |||
|
|
|||
| return "" | |||
| return codersdk.UsageAppNameSSH | |||
There was a problem hiding this comment.
Letting the zero value mean 'disabled' feels more idiomatic to me, but 'disabled' is way more explicit and better from a user perspective.
There was a problem hiding this comment.
I considered having the default value on the flag be ssh and disable reporting if it's manually set to empty string but I wasn't sure if that was explicit enough behavior. I'm thinking in the extensions where we do CODER_SSH_USAGE_APP_NAME="" coder ssh ... I'm worried there may be cases where the empty string get's passed to the CLI as "unset" instead.
deansheather
approved these changes
Jun 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
coderdto only allow a single endpoint to write ssh session data to the DB at a time. Both the CLI and the agent will always report stats, but the agent endpoint will silently drop session stats while the experimentworkspace-usageis enabled. This prevents us from double-counting stats during the migration period.We will need to give end users sufficient time to update their CLI and extensions before moving this behavior to GA otherwise outdated clients will have their data dropped until they upgrade.