Skip to content

feat: add groups and group members to telemetry snapshot #13655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 25, 2024
Merged

feat: add groups and group members to telemetry snapshot #13655

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
139adf6
feat: added status to the return value of ConvertUsers and removed lo…
austinrhode Jun 20, 2024
c665b4a
feat: Added in groups and groups members to telemetry snapshot
austinrhode Jun 24, 2024
c865d65
chore: removed dead code
austinrhode Jun 24, 2024
be0c1f5
Merge branch 'main' into austinrhode/groups
austinrhode Jun 25, 2024
c4b12de
chore: update variable name to not include an underscore
austinrhode Jun 25, 2024
4b3e975
feat: adding in test to dbauthz for getting group members and groups
austinrhode Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: added status to the return value of ConvertUsers and removed lo… 
…gic to ignore non-active users when creating a snapshot
  • Loading branch information
@austinrhode
austinrhode committed Jun 20, 2024
commit 139adf604e9dfd8ab0bfcb433cfa90d70fb38897
4 changes: 1 addition & 3 deletions coderd/telemetry/telemetry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,9 +353,6 @@ func (r *remoteReporter) createSnapshot() (*Snapshot, error) {
users := database.ConvertUserRows(userRows)
var firstUser database.User
for _, dbUser := range users {
if dbUser.Status != database.UserStatusActive {
continue
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is from your previous pr #13613

if firstUser.CreatedAt.IsZero() {
firstUser = dbUser
}
Expand Down Expand Up @@ -655,6 +652,7 @@ func ConvertUser(dbUser database.User) User {
EmailHashed: emailHashed,
RBACRoles: dbUser.RBACRoles,
CreatedAt: dbUser.CreatedAt,
Status: dbUser.Status,
}
}

Expand Down
Loading