Skip to content

feat: add docstrings to mock timer and ticker methods and structs #13658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2024
Merged

feat: add docstrings to mock timer and ticker methods and structs #13658

merged 1 commit into from
Jun 25, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Jun 25, 2024 •
edited
Loading

Adds docstrings to structs and methods, copying from the standard time package.

This was referenced Jun 25, 2024
Merged
Merged
Merged
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Jun 25, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

@spikecurtis spikecurtis mentioned this pull request Jun 25, 2024
Merged
@spikecurtis spikecurtis requested review from johnstcn and mafredri June 25, 2024 12:26
@spikecurtis spikecurtis marked this pull request as ready for review June 25, 2024 12:27
@spikecurtis spikecurtis force-pushed the spike/clock-testing-next branch from 93b53f2 to d153c36 Compare June 25, 2024 12:35
@spikecurtis spikecurtis force-pushed the spike/clock-testing-ticker-timer-docstrings branch from f9196ad to 141e728 Compare June 25, 2024 12:36
@spikecurtis spikecurtis force-pushed the spike/clock-testing-next branch 2 times, most recently from 5fb9cfe to efa2738 Compare June 25, 2024 12:39
@spikecurtis spikecurtis force-pushed the spike/clock-testing-ticker-timer-docstrings branch from 141e728 to 834f943 Compare June 25, 2024 12:39
Base automatically changed from spike/clock-testing-next to main June 25, 2024 12:48
@spikecurtis spikecurtis force-pushed the spike/clock-testing-ticker-timer-docstrings branch from 834f943 to f551f5e Compare June 25, 2024 12:51
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Jun 25, 2024 •
edited
Loading

Merge activity

  • Jun 25, 8:51 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 25, 8:59 AM EDT: @spikecurtis merged this pull request with Graphite.

@spikecurtis spikecurtis merged commit 9c1a6a2 into main Jun 25, 2024
27 checks passed
@spikecurtis spikecurtis deleted the spike/clock-testing-ticker-timer-docstrings branch June 25, 2024 12:59
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spikecurtis @johnstcn