Skip to content

feat: add "Full Name" field to user creation #13659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2024
Merged

feat: add "Full Name" field to user creation #13659

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ec27e9
feat: add "Full Name" field to user creation
johnstcn Jun 6, 2024
08eb15f
address PR comments
johnstcn Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
address PR comments
  • Loading branch information
@johnstcn
johnstcn committed Jun 25, 2024
commit 08eb15fbceb05ab8457098cd1dce02fc787ec2e4
6 changes: 0 additions & 6 deletions site/src/pages/CreateUserPage/CreateUserForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ export const Language = {
passwordLabel: "Password",
usernameLabel: "Username",
nameLabel: "Full name",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I would use "Name" instead of "Full name".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I would much prefer to use "full name" in the UI/CLI to distinguish it from "username". The API refers to it as name however.

nameHelperText: "Optional human-readable name",
emailInvalid: "Please enter a valid email address.",
emailRequired: "Please enter an email address.",
passwordRequired: "Please enter a password.",
Expand Down Expand Up @@ -131,14 +130,9 @@ export const CreateUserForm: FC<
/>
<TextField
{...getFieldHelpers("name")}
onBlur={(e) => {
e.target.value = e.target.value.trim();
form.handleChange(e);
}}
autoComplete="name"
fullWidth
label={Language.nameLabel}
helperText={Language.nameHelperText}
/>
<TextField
{...getFieldHelpers("email")}
Expand Down
6 changes: 0 additions & 6 deletions site/src/pages/SetupPage/SetupPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ export const Language = {
emailLabel: "Email",
passwordLabel: "Password",
nameLabel: "Full Name",
nameHelperText: "Optional human-readable name",
usernameLabel: "Username",
emailInvalid: "Please enter a valid email address.",
emailRequired: "Please enter an email address.",
Expand Down Expand Up @@ -157,14 +156,9 @@ export const SetupPageView: FC<SetupPageViewProps> = ({
/>
<TextField
{...getFieldHelpers("name")}
onBlur={(e) => {
e.target.value = e.target.value.trim();
form.handleChange(e);
}}
autoComplete="name"
fullWidth
label={Language.nameLabel}
helperText={Language.nameHelperText}
/>
<TextField
{...getFieldHelpers("email")}
Expand Down