Skip to content

chore: implement organization scoped audit log requests #13663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 26, 2024
Merged

chore: implement organization scoped audit log requests #13663

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
23c34c4
chore: add organization_id filter to audit logs
Emyrk Jun 25, 2024
2950d04
dbauthz
Emyrk Jun 25, 2024
555b045
chore: implement organization scoped audit log requests
Emyrk Jun 25, 2024
b9ccc5a
fixup
Emyrk Jun 25, 2024
e6d415a
make gen
Emyrk Jun 25, 2024
1cb0c20
fix pagination
Emyrk Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix pagination
  • Loading branch information
@Emyrk
Emyrk committed Jun 26, 2024
commit 1cb0c20217a5ddd84fba620d2cb82f20bbc7af14
9 changes: 8 additions & 1 deletion coderd/audit_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,11 @@ func TestAuditLogs(t *testing.T) {
require.NoError(t, err)

// Fetching audit logs without an organization selector should fail
_, err = orgAdmin.AuditLogs(ctx, codersdk.AuditLogsRequest{})
_, err = orgAdmin.AuditLogs(ctx, codersdk.AuditLogsRequest{
Pagination: codersdk.Pagination{
Limit: 5,
},
})
var sdkError *codersdk.Error
require.Error(t, err)
require.ErrorAsf(t, err, &sdkError, "error should be of type *codersdk.Error")
Expand All @@ -174,6 +178,9 @@ func TestAuditLogs(t *testing.T) {
// Using the organization selector allows the org admin to fetch audit logs
alogs, err := orgAdmin.AuditLogs(ctx, codersdk.AuditLogsRequest{
SearchQuery: fmt.Sprintf("organization_id:%s", owner.OrganizationID.String()),
Pagination: codersdk.Pagination{
Limit: 5,
},
})
require.NoError(t, err)
require.Len(t, alogs.AuditLogs, 1)
Expand Down