Skip to content

fix: disable agent app buttons while a blocking startup script is running #13667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2024
Merged

fix: disable agent app buttons while a blocking startup script is running #13667

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ad1dfe
fix: disable agent app buttons until startup script is completes when…
aslilac Jun 25, 2024
4096570
🧹
aslilac Jun 26, 2024
09e52ea
cry
aslilac Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
🧹
  • Loading branch information
@aslilac
aslilac committed Jun 26, 2024
commit 4096570d2af50d4d0cdffb56c9bb7933b64cb7d1
12 changes: 12 additions & 0 deletions site/src/modules/resources/AppLink/AppLink.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,3 +151,15 @@ export const InternalApp: Story = {
agent: MockWorkspaceAgent,
},
};

export const BlockingStartupScriptRunning: Story = {
args: {
workspace: MockWorkspace,
app: MockWorkspaceApp,
agent: {
...MockWorkspaceAgent,
lifecycle_state: "starting",
startup_script_behavior: "blocking",
},
},
};
4 changes: 2 additions & 2 deletions site/src/modules/resources/AppLink/AppLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ import { ShareIcon } from "./ShareIcon";
export const DisplayAppNameMap: Record<TypesGen.DisplayApp, string> = {
port_forwarding_helper: "Ports",
ssh_helper: "SSH",
vscode: "VS Code",
vscode_insiders: "VS Code Insiders",
vscode: "VS Code (Remote)",
vscode_insiders: "VS Code Insiders (Remote)",
web_terminal: "Terminal",
};

Expand Down