Skip to content

fix: improve checkbox text in template schedule settings dialog #13669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 27, 2024
Merged

fix: improve checkbox text in template schedule settings dialog #13669

merged 4 commits into from
Jun 27, 2024

Conversation

jaaydenh
Copy link
Contributor

Fixes #13344

  • Update ScheduleDialog text
  • Add storybook story for ScheduleDialog

@jaaydenh jaaydenh requested a review from aslilac June 26, 2024 03:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@jaaydenh
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

cdrcommunity added a commit to coder/cla that referenced this pull request Jun 26, 2024
@cdrcommunity
@jaaydenh has signed the CLA in coder/coder#13669
4671b1f
aslilac
aslilac approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! just a couple small language changes that would be nice, but the code looks good

@jaaydenh jaaydenh merged commit 093ec3d into main Jun 27, 2024
29 checks passed
@jaaydenh jaaydenh deleted the dormancy-checkbox-text branch June 27, 2024 17:14
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aslilac aslilac aslilac approved these changes

Assignees

@jaaydenh jaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird confirmation for dormancy warning in template schedule settings
2 participants
@jaaydenh @aslilac