Skip to content

chore: add DRPC tailnet & cli network telemetry #13687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 3, 2024
Merged

chore: add DRPC tailnet & cli network telemetry #13687

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
974c570
chore: add DRPC tailnet & cli implementation
ethanndickson Jun 26, 2024
0718987
fixup
ethanndickson Jun 26, 2024
80181ad
fixup
ethanndickson Jun 26, 2024
3b7f5b2
wip log sink
ethanndickson Jun 27, 2024
66313d1
derpmap telemetry clean
ethanndickson Jun 28, 2024
09d9249
netcheck stub
ethanndickson Jun 28, 2024
5c0f30c
add netcheck
ethanndickson Jul 1, 2024
45b5234
fixup
ethanndickson Jul 1, 2024
f83df79
tests
ethanndickson Jul 1, 2024
b9cd8fb
ping and speedtest telemetry
ethanndickson Jul 1, 2024
ce0df7b
fixup
ethanndickson Jul 2, 2024
598cad5
bump tailscale, change api
ethanndickson Jul 2, 2024
6a3480c
remove logs
ethanndickson Jul 2, 2024
f33ab36
populate latency, node ids, home derp
ethanndickson Jul 2, 2024
3918369
update flake
ethanndickson Jul 2, 2024
b9cfa52
fixup
ethanndickson Jul 2, 2024
c0684bb
application field
ethanndickson Jul 2, 2024
67898fd
review
ethanndickson Jul 3, 2024
ffd62ca
telemetry on disconnect
ethanndickson Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@ethanndickson
ethanndickson committed Jul 2, 2024
commit 0718987f971ac906cad993ad29968d8802b78c0b
6 changes: 1 addition & 5 deletions codersdk/workspacesdk/connector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ type tailnetConn interface {
//
// 1) run the Coordinate API and pass node information back and forth
// 2) stream DERPMap updates and program the Conn
// 3) Send network telemetry events
//
// These functions share the same websocket, and so are combined here so that if we hit a problem
// we tear the whole thing down and start over with a new websocket.
Expand All @@ -58,7 +59,6 @@ type tailnetAPIConnector struct {
coordinateURL string
dialOptions *websocket.DialOptions
conn tailnetConn
customDialFn func() (proto.DRPCTailnetClient, error)

clientMu sync.RWMutex
client proto.DRPCTailnetClient
Expand Down Expand Up @@ -125,10 +125,6 @@ var permanentErrorStatuses = []int{
}

func (tac *tailnetAPIConnector) dial() (proto.DRPCTailnetClient, error) {
if tac.customDialFn != nil {
return tac.customDialFn()
}

tac.logger.Debug(tac.ctx, "dialing Coder tailnet v2+ API")
// nolint:bodyclose
ws, res, err := websocket.Dial(tac.ctx, tac.coordinateURL, tac.dialOptions)
Expand Down