Skip to content

chore: revert to default survey templates #13690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jun 27, 2024

Changes

Revert to the default template provided by the package. Includes all fields like the "Message" field. Our template omits headers and keybind helpers.

Changes answer selector from green to cyan. Fixing this requires us to edit the global template, which is really unfortunate.

Confirm

Comparison

Before

Screencast.from.2024-06-27.09-45-38.webm

After

Screencast.from.2024-06-27.09-54-41.webm

Multi-Select

Comparison

Before

Screencast.from.2024-06-27.09-47-20.webm

After

Screencast.from.2024-06-27.09-56-00.webm

Rich Parameters

Comparison

Before

Screencast.from.2024-06-27.09-48-33.webm

After

Screencast.from.2024-06-27.09-57-21.webm

Secret Input

Comparison

Before

Screencast.from.2024-06-27.09-48-58.webm

After

Screencast.from.2024-06-27.09-58-00.webm

Basic Input

Comparison

Before

Screencast.from.2024-06-27.09-49-33.webm

After

Screencast.from.2024-06-27.09-58-26.webm

Select

Comparison

Before

Screencast.from.2024-06-27.09-49-58.webm

After

Screencast.from.2024-06-27.09-58-59.webm

Commentary

Would be ideal if we could tweak the original template (like color choice) without having to replace the template entirely 😢.

Copy link
Member Author

Emyrk commented Jun 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Emyrk and the rest of your teammates on Graphite Graphite

@Emyrk Emyrk marked this pull request as ready for review June 27, 2024 15:06
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed recordings and acknowledges changes 👍 I don't suspect anything breaking here.

Base automatically changed from stevenmasley/survey_prompt to main June 27, 2024 15:20
@Emyrk Emyrk force-pushed the stevenmasley/fix_survey branch from 92d93e0 to 1953405 Compare June 27, 2024 15:21
@Emyrk Emyrk merged commit 5a0afd8 into main Jun 27, 2024
28 checks passed
@Emyrk Emyrk deleted the stevenmasley/fix_survey branch June 27, 2024 15:32
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants