Skip to content

feat: route groups by name instead of id #13692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 1, 2024
Merged

feat: route groups by name instead of id #13692

merged 6 commits into from
Jul 1, 2024

Conversation

jaaydenh
Copy link
Contributor

Resolves #13599

@jaaydenh jaaydenh self-assigned this Jun 27, 2024
@jaaydenh jaaydenh marked this pull request as ready for review June 27, 2024 21:25
@jaaydenh jaaydenh requested review from aslilac and kylecarbs June 28, 2024 17:28
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small suggestion, but otherwise looks good!

@aslilac aslilac dismissed kylecarbs’s stale review June 28, 2024 17:41

will be fixed later

@jaaydenh jaaydenh merged commit f26f123 into main Jul 1, 2024
29 checks passed
@jaaydenh jaaydenh deleted the group-route-by-name branch July 1, 2024 19:48
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group settings page should be routed by name instead of ID
3 participants