Skip to content

Conversation

ericpaulsen
Copy link
Member

this moves our architecture documentation to the top level, and adds a nice container SVG for the icon.

@ericpaulsen ericpaulsen added the docs Area: coder.com/docs label Jun 28, 2024
@ericpaulsen ericpaulsen self-assigned this Jun 28, 2024
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple incorrect links in the refactor.
Please see: https://github.com/coder/coder/actions/runs/9716022262/job/26818707420?pr=13722#step:4:1048

@ericpaulsen
Copy link
Member Author

done @matifali

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stirby @bpmct, does it conflict with the refactoring you are doing for #13434 at https://coder.com/docs/@restructure?

I am waiting for your response otherwise, LGTM.

@ericpaulsen ericpaulsen requested a review from matifali June 28, 2024 23:13
@matifali matifali dismissed their stale review June 29, 2024 06:20

Resolved dead links

Copy link
Collaborator

@stirby stirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be overwritten by the restructure, but we can revisit it's placement or linking it in the homepage when that's merged.

@ericpaulsen ericpaulsen merged commit d8d86b1 into main Jul 1, 2024
@ericpaulsen ericpaulsen deleted the reorg-arch branch July 1, 2024 15:58
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Area: coder.com/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants