Skip to content

chore: update mui #13747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 2, 2024
Merged

chore: update mui #13747

merged 4 commits into from
Jul 2, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Jul 1, 2024

Closes #13734

dependabot wants to update, but isn't smart enough to group these updates

@aslilac aslilac requested review from a team and Parkreiner and removed request for a team July 1, 2024 18:13
@Parkreiner
Copy link
Member

Parkreiner commented Jul 2, 2024

I'll kick the tires a bit in about 30 minutes

Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried a lot of the pages and components that use MUI a lot, and didn't notice any problems. Think this is safe to merge

css={{
pointerEvents: canClick ? undefined : "none",
textDecoration: "none !important",
}}
onClick={async (event) => {
onClick={async (event: MouseEvent<HTMLElement>) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried seeing what would happen if I removed the type annotation, and man, MUI really is a disaster of megamorphic abstractions, huh

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, yes it is :^)

@aslilac aslilac merged commit bfbf634 into main Jul 2, 2024
29 checks passed
@aslilac aslilac deleted the update-mui branch July 2, 2024 21:19
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants