Skip to content

chore: remove database import from cli #13756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2024
Merged

chore: remove database import from cli #13756

merged 1 commit into from
Jul 1, 2024

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jul 1, 2024 •
edited
Loading

Cli was using a utility function from a database package. Was causing a build issue for slim binaries.

@Emyrk
hotfix: remove database import from cli
0d52bb0 
Cli was using a utility function from a database package.
@Emyrk Emyrk added the hotfix PRs only. Harmless small change. Only humans may set this. label Jul 1, 2024
cdr-bot[bot]
cdr-bot bot approved these changes Jul 1, 2024
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@Emyrk Emyrk changed the title hotfix: remove database import from cli chore: remove database import from cli Jul 1, 2024
@Emyrk Emyrk enabled auto-merge (squash) July 1, 2024 21:53
@Emyrk Emyrk merged commit abc0ff9 into main Jul 1, 2024
38 checks passed
@Emyrk Emyrk deleted the stevenmasley/import_fix branch July 1, 2024 21:58
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@Emyrk Emyrk

Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Emyrk