Skip to content

chore: add SVG desktop icon #13765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2024
Merged

chore: add SVG desktop icon #13765

merged 2 commits into from
Jul 2, 2024

Conversation

Parkreiner
Copy link
Member

Needed for coder/modules#234
This is the icon that will be used for the Web RDP Coder module.

@Parkreiner Parkreiner self-assigned this Jul 2, 2024
@Parkreiner Parkreiner added the hotfix PRs only. Harmless small change. Only humans may set this. label Jul 2, 2024
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@Parkreiner Parkreiner enabled auto-merge (squash) July 2, 2024 15:42
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just copy-and-pasted the icon that we were using for development of the RDP module, but added some extra XML data to ensure that the file meets all W3 validation criteria

@Parkreiner Parkreiner disabled auto-merge July 2, 2024 15:56
@Parkreiner Parkreiner enabled auto-merge (squash) July 2, 2024 15:58
@Parkreiner Parkreiner merged commit 21a923a into main Jul 2, 2024
29 checks passed
@Parkreiner Parkreiner deleted the mes/desktop-icon branch July 2, 2024 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant