Skip to content

ci: remove release make concurrency to fix docker image race #13769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2024
Merged

ci: remove release make concurrency to fix docker image race #13769

merged 1 commit into from
Jul 2, 2024

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Jul 2, 2024 •
edited
Loading

Our ghcr.io/coder/coder-base:v2.13.0 image shares the same SHA256 for all platforms, this presumably resulted in a race where the arm64 image overwrote the amd64 image just as the build was getting going:

https://github.com/coder/coder/actions/runs/9765191341/job/26955318156#step:28:321

Ref #13770.

@mafredri mafredri added the hotfix PRs only. Harmless small change. Only humans may set this. label Jul 2, 2024
@mafredri mafredri self-assigned this Jul 2, 2024
@mafredri mafredri requested review from johnstcn and stirby July 2, 2024 17:45
cdr-bot[bot]
cdr-bot bot approved these changes Jul 2, 2024
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

stirby
stirby approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@stirby stirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@mafredri mafredri changed the title chore(.github): remove release make concurrency to fix docker image race chore(ci): remove release make concurrency to fix docker image race Jul 2, 2024
@mafredri mafredri changed the title chore(ci): remove release make concurrency to fix docker image race ci: remove release make concurrency to fix docker image race Jul 2, 2024
@mafredri mafredri enabled auto-merge (squash) July 2, 2024 17:48
@mafredri mafredri merged commit a114288 into main Jul 2, 2024
35 checks passed
@mafredri mafredri deleted the mafredri/fix-release-workflow-disable-concurrent-make branch July 2, 2024 17:49
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@stirby stirby stirby approved these changes

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@mafredri mafredri

Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mafredri @johnstcn @stirby