feat: implement multi-org template gallery #13784
Conversation
fa872e0 to
63827ef
Compare
|
I have a few design considerations. I believe we can avoid adding more components and create another view solely for filtering based on organizations. We could achieve this using pills as filters or by replicating what we have for workspaces. Pills:
Replicating Workspaces:
|
89e54a4 to
bd2bb03
Compare
|
|
||
| export const TemplateCard: FC<TemplateCardProps> = ({ | ||
| template, | ||
| ...divProps |
There was a problem hiding this comment.
super minor nit, I tend to call these sorts of captures attrs, but there's definitely precedent for calling it whateverProps too. maybe this is something we should consolidate on...
There was a problem hiding this comment.
I was following the pattern in the files I was working on. In other code bases/the React docs, this is often called ...props as well. I think it depends if we want to call them based on what they are, "props" or how they are used, props on divs "divProps" or attributes on divs "attrs"
@aslilac Can you comment on the feedback from @BrunoQuaresma as you have more context around the design decisions? |
fc2e6f9 to
801138a
Compare
|
@BrunoQuaresma the design is based off of the starter template gallery, and aims to bring some distinction between the appearance of workspace related pages and the appearance of the template related pages. investigating the pills idea sounds interesting, but we can mess with the design more after the experiment has shipped. |
Resolves #13775
MultiOrgTemplatesPageViewusing a grid layoutMultiOrgTemplatesPageViewTemplateCard