feat: autostop workspaces owned by suspended users #13790
Conversation
| @@ -387,6 +387,10 @@ func isEligibleForAutostop(ws database.Workspace, build database.WorkspaceBuild, | |||
| return false | |||
| } | |||
|
|
|||
| if build.Transition == database.WorkspaceTransitionStart && user.Status == database.UserStatusSuspended { | |||
There was a problem hiding this comment.
Do we care about any other user statuses?
There was a problem hiding this comment.
No, I don't want to mess with others - just suspended.
There was a problem hiding this comment.
I was going to mention dormant but figured it was out of scope; should dormant users be allowed to run workloads?
There was a problem hiding this comment.
IIRC on the first interaction with API the dormant user will be switched to active, so yes.
There was a problem hiding this comment.
By definition... they shouldn't be able to...? Once they log in, they're active.
There was a problem hiding this comment.
Ok, what is your preference - should I extend the logic to dormant users too?
There was a problem hiding this comment.
I think it could be a follow-up PR since there may be additional considerations.
| // When: the autobuild executor ticks after the scheduled time | ||
| go func() { | ||
| tickCh <- sched.Next(workspace.LatestBuild.CreatedAt) | ||
| close(tickCh) | ||
| }() |
There was a problem hiding this comment.
Do we want the executor to immediately stop workspaces of suspended users, or wait until the workspace has its time to shut down? This is testing the latter.
There was a problem hiding this comment.
I assume that the lifecycle executor stops the workspace right after the conditional logic is satisfied? Do you have a specific idea in mind on how we can improve testing?
There was a problem hiding this comment.
No matter what time you send down the channel, it should result in the workspace being stopped.
There was a problem hiding this comment.
Thanks for more context. I excluded sched from the test.
Fixed: #8051
This PR modifies autostop rules to stop workspaces owned by suspended users.