Skip to content

feat(codersdk/agentsdk): export LogDest interface #13792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jul 4, 2024

This makes it possible to test SendLoop externally.

@johnstcn johnstcn self-assigned this Jul 4, 2024
Signed-off-by: Cian Johnston <cian@coder.com>
@johnstcn johnstcn force-pushed the cj/expose-agentsdk-logdest branch from 30d54e2 to dc21a6e Compare July 4, 2024 12:20
@johnstcn johnstcn changed the title feat(agentsdk): export LogDest interface feat(codersdk/agentsdk): export LogDest interface Jul 4, 2024
@johnstcn johnstcn requested review from spikecurtis, mafredri, dannykopping and mtojek and removed request for spikecurtis July 4, 2024 12:34
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnstcn johnstcn merged commit c2d44d1 into main Jul 4, 2024
34 checks passed
@johnstcn johnstcn deleted the cj/expose-agentsdk-logdest branch July 4, 2024 13:04
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants