Skip to content

feat: add killswitch for notifications #13794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 10, 2024
Merged

feat: add killswitch for notifications #13794

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
735d0ef
feat: add killswitch for notifications
mtojek Jul 9, 2024
b6338e5
revert
mtojek Jul 10, 2024
16c8950
migrate down
mtojek Jul 10, 2024
edfff5e
304
mtojek Jul 10, 2024
89e1396
Notifications settings
mtojek Jul 10, 2024
ab8a6c7
debug message
mtojek Jul 10, 2024
2522366
return true
mtojek Jul 10, 2024
7dfbd29
remove WillUsePostgres
mtojek Jul 10, 2024
d7f470d
Merge branch 'main' into 4-pause-1
mtojek Jul 10, 2024
6abf39f
fix client 304
mtojek Jul 10, 2024
341485f
createSampleUser
mtojek Jul 10, 2024
c90ff21
sdkError
mtojek Jul 10, 2024
da6775f
remove test for not modified
mtojek Jul 10, 2024
9d430bb
swagger update
mtojek Jul 10, 2024
a55fc8a
bring back Settings not modified
mtojek Jul 10, 2024
af36afb
enable WillUsePostgres in TestWebhookDispatch
mtojek Jul 10, 2024
7e8ad09
refactor Settings not modified
mtojek Jul 10, 2024
ce1a9e9
refactored TestNotifierPaused
mtojek Jul 10, 2024
dbf6a40
bug: RLock RUnlock
mtojek Jul 10, 2024
c2e181c
Danny's review
mtojek Jul 10, 2024
fa0f381
Merge branch 'main' into 4-pause-1
mtojek Jul 10, 2024
83978e7
fix
mtojek Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove test for not modified
  • Loading branch information
@mtojek
mtojek committed Jul 10, 2024
commit da6775f8c4543ac63371265cd869e5514257eece
20 changes: 0 additions & 20 deletions coderd/notifications_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,24 +60,4 @@ func TestUpdateNotificationsSettings(t *testing.T) {
require.NoError(t, err)
require.Equal(t, expected, actual)
})

t.Run("Settings not modified", func(t *testing.T) {
t.Parallel()

client := coderdtest.New(t, nil)
_ = coderdtest.CreateFirstUser(t, client)

ctx := testutil.Context(t, testutil.WaitShort)

// given
expected := codersdk.NotificationsSettings{
NotifierPaused: false,
}
err := client.PutNotificationsSettings(ctx, expected)
require.NoError(t, err)

// then
err = client.PutNotificationsSettings(ctx, expected)
require.Error(t, err) // Error: notifications settings not modified
})
}
4 changes: 1 addition & 3 deletions codersdk/notifications.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ import (
"context"
"encoding/json"
"net/http"

"golang.org/x/xerrors"
)

type NotificationsSettings struct {
Expand Down Expand Up @@ -33,7 +31,7 @@ func (c *Client) PutNotificationsSettings(ctx context.Context, settings Notifica
defer res.Body.Close()

if res.StatusCode == http.StatusNotModified {
return xerrors.New("notifications settings not modified")
return nil
}
if res.StatusCode != http.StatusOK {
return ReadBodyAsError(res)
Expand Down
Loading