Skip to content

chore(examples): update sample devcontainer templates #13796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 22, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jul 5, 2024

Part of coder/envbuilder#131

Kubernetes tested locally with KinD.

@johnstcn johnstcn self-assigned this Jul 5, 2024
@johnstcn johnstcn marked this pull request as ready for review July 5, 2024 16:57
kubernetes = {
source = "hashicorp/kubernetes"
docker = {
source = "kreuzwerker/docker"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment on why the kubernetes template uses kreuzwerker/docker

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, bad copy-paste

@github-actions github-actions bot added the stale This issue is like stale bread. label Jul 16, 2024
@github-actions github-actions bot closed this Jul 20, 2024
@johnstcn johnstcn reopened this Jul 22, 2024
@johnstcn johnstcn force-pushed the cj/update-devcontainer-templates branch from 81b4b75 to 140f208 Compare July 22, 2024 10:19
@johnstcn johnstcn merged commit 005254d into main Jul 22, 2024
27 checks passed
@johnstcn johnstcn deleted the cj/update-devcontainer-templates branch July 22, 2024 13:10
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale This issue is like stale bread.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants