Add support for match in the auto create flow

coder · BrunoQuaresma · Jul 9, 2024 · Jul 8, 2024 · Jul 8, 2024 · Jul 8, 2024
commit 48d0e39c625d322f977be532b097b133c8ba5a17
diff --git a/site/src/api/errors.ts b/site/src/api/errors.ts
@@ -111,6 +111,10 @@ export const getValidationErrorMessage = (error: unknown): string => {
 };
 
 export const getErrorDetail = (error: unknown): string | undefined => {
+  if (error instanceof DetailedError) {
+    return error.detail;
+  }
+
   if (error instanceof Error) {
     return "Please check the developer console for more details.";
   }
@@ -125,3 +129,12 @@ export const getErrorDetail = (error: unknown): string | undefined => {
 
   return undefined;
 };
+
+export class DetailedError extends Error {
+  constructor(
+    message: string,
+    public detail?: string,
+  ) {
+    super(message);
+  }
+}
diff --git a/site/src/api/queries/workspaces.ts b/site/src/api/queries/workspaces.ts
@@ -5,6 +5,7 @@ import type {
   UseMutationOptions,
 } from "react-query";
 import { type DeleteWorkspaceOptions, API } from "api/api";
+import { DetailedError, isApiValidationError } from "api/errors";
 import type {
   CreateWorkspaceRequest,
   ProvisionerLogLevel,
@@ -36,14 +37,6 @@ export const workspaceByOwnerAndName = (owner: string, name: string) => {
   };
 };
 
-type AutoCreateWorkspaceOptions = {
-  templateName: string;
-  versionId?: string;
-  organizationId: string;
-  defaultBuildParameters?: WorkspaceBuildParameter[];
-  defaultName: string;
-};
-
 type CreateWorkspaceMutationVariables = CreateWorkspaceRequest & {
   userId: string;
   organizationId: string;
@@ -61,15 +54,41 @@ export const createWorkspace = (queryClient: QueryClient) => {
   };
 };
 
+type AutoCreateWorkspaceOptions = {
+  organizationId: string;
+  templateName: string;
+  name: string;
+  /**
+   * If provided, the auto-create workspace feature will attempt to find a
+   * matching workspace. If found, it will return the existing workspace instead
+   * of creating a new one. Its value supports [advanced filtering queries for
+   * workspaces](https://coder.com/docs/workspaces#workspace-filtering). If
+   * multiple values are returned, the first one will be returned.
+   */
+  match: string | null;
+  versionId?: string;
+  buildParameters?: WorkspaceBuildParameter[];
+};
+
 export const autoCreateWorkspace = (queryClient: QueryClient) => {
   return {
     mutationFn: async ({
+      organizationId,
       templateName,
+      name,
       versionId,
-      organizationId,
-      defaultBuildParameters,
-      defaultName,
+      buildParameters,
+      match,
     }: AutoCreateWorkspaceOptions) => {
+      if (match) {
+        const matchWorkspace = await findMatchWorkspace(
+          `owner:me template:${templateName} ${match}`,
+        );
+        if (matchWorkspace) {
+          return matchWorkspace;
+        }
+      }
+
       let templateVersionParameters;
 
       if (versionId) {
@@ -84,8 +103,8 @@ export const autoCreateWorkspace = (queryClient: QueryClient) => {
 
       return API.createWorkspace(organizationId, "me", {
         ...templateVersionParameters,
-        name: defaultName,
-        rich_parameter_values: defaultBuildParameters,
+        name,
+        rich_parameter_values: buildParameters,
       });
     },
     onSuccess: async () => {
@@ -94,6 +113,27 @@ export const autoCreateWorkspace = (queryClient: QueryClient) => {
   };
 };
 
+async function findMatchWorkspace(q: string): Promise<Workspace | undefined> {
+  try {
+    const { workspaces } = await API.getWorkspaces({ q });
+    const matchWorkspace = workspaces.at(0);
+    if (matchWorkspace) {
+      return matchWorkspace;
+    }
+  } catch (err) {
+    if (isApiValidationError(err)) {
+      const firstValidationErrorDetail =
+        err.response.data.validations?.[0].detail;
+      throw new DetailedError(
+        "Invalid match value",
+        firstValidationErrorDetail,
+      );
+    }
+
+    throw err;
+  }
+}
+
 export function workspacesKey(config: WorkspacesRequest = {}) {
   const { q, limit } = config;
   return ["workspaces", { q, limit }] as const;

diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePage.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePage.tsx
@@ -16,7 +16,6 @@ import type {
   UserParameter,
   Workspace,
 } from "api/typesGenerated";
-import { ErrorAlert } from "components/Alert/ErrorAlert";
 import { Loader } from "components/Loader/Loader";
 import { useAuthenticated } from "contexts/auth/RequireAuth";
 import { useEffectEvent } from "hooks/hookPolyfills";
@@ -37,7 +36,7 @@ const CreateWorkspacePage: FC = () => {
   const { template: templateName } = useParams() as { template: string };
   const { user: me } = useAuthenticated();
   const navigate = useNavigate();
-  const [searchParams, setSearchParams] = useSearchParams();
+  const [searchParams] = useSearchParams();
   const { experiments, organizationId } = useDashboard();
 
   const customVersionId = searchParams.get("version") ?? undefined;
@@ -118,15 +117,15 @@ const CreateWorkspacePage: FC = () => {
       const newWorkspace = await autoCreateWorkspaceMutation.mutateAsync({
         templateName,
         organizationId,
-        defaultBuildParameters: autofillParameters,
-        defaultName: defaultName ?? generateWorkspaceName(),
+        buildParameters: autofillParameters,
+        name: defaultName ?? generateWorkspaceName(),
         versionId: realizedVersionId,
+        match: searchParams.get("match"),
       });
 
       onCreateWorkspace(newWorkspace);
     } catch (err) {
-      searchParams.delete("mode");
-      setSearchParams(searchParams);
+      setMode("form");
     }
   });
 
@@ -175,7 +174,6 @@ const CreateWorkspacePage: FC = () => {
       <Helmet>
         <title>{pageTitle(title)}</title>
       </Helmet>
-      {loadFormDataError && <ErrorAlert error={loadFormDataError} />}
       {isLoadingFormData || isLoadingExternalAuth || autoCreateReady ? (
         <Loader />
       ) : (
@@ -185,7 +183,12 @@ const CreateWorkspacePage: FC = () => {
           disabledParams={disabledParams}
           defaultOwner={me}
           autofillParameters={autofillParameters}
-          error={createWorkspaceMutation.error || autoCreateError}
+          error={
+            createWorkspaceMutation.error ||
+            autoCreateError ||
+            loadFormDataError ||
+            autoCreateWorkspaceMutation.error
+          }
           resetMutation={createWorkspaceMutation.reset}
           template={templateQuery.data!}
           versionId={realizedVersionId}