Skip to content

chore: add "needs grooming" label to new issues #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2022
Merged

chore: add "needs grooming" label to new issues #1384

merged 1 commit into from
May 11, 2022

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented May 11, 2022

No description provided.

@bpmct bpmct requested review from misskniss and jsjoeio May 11, 2022 13:00
@bpmct bpmct self-assigned this May 11, 2022
@codecov
Copy link

codecov bot commented May 11, 2022 •
edited
Loading

Codecov Report

Merging #1384 (38220fd) into main (9d94f4f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1384   +/-   ##
=======================================
  Coverage   66.93%   66.93%           
=======================================
  Files         288      288           
  Lines       18856    18856           
  Branches      241      241           
=======================================
  Hits        12622    12622           
+ Misses       4944     4942    -2     
- Partials     1290     1292    +2
Flag Coverage Δ
unittest-go-macos-latest 53.96% <ø> (-0.12%) ⬇️
unittest-go-postgres- 65.42% <ø> (+<0.01%) ⬆️
unittest-go-ubuntu-latest 56.41% <ø> (+0.02%) ⬆️
unittest-go-windows-2022 52.41% <ø> (+0.03%) ⬆️
unittest-js 74.24% <ø> (ø)
Impacted Files Coverage Δ
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
peerbroker/dial.go 77.04% <0.00%> (-6.56%) ⬇️
coderd/turnconn/turnconn.go 81.91% <0.00%> (-3.20%) ⬇️
codersdk/workspaceagents.go 51.52% <0.00%> (-1.36%) ⬇️
agent/agent.go 65.90% <0.00%> (-1.24%) ⬇️
provisionerd/provisionerd.go 75.76% <0.00%> (-0.41%) ⬇️
coderd/workspaceagents.go 57.90% <0.00%> (+1.86%) ⬆️
peer/conn.go 80.34% <0.00%> (+1.96%) ⬆️
cli/cliui/provisionerjob.go 78.57% <0.00%> (+2.14%) ⬆️
peerbroker/listen.go 87.39% <0.00%> (+3.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d94f4f...38220fd. Read the comment docs.

kylecarbs
kylecarbs reviewed May 11, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An external contributor won't know how to take action on this. Could we assume issues without labels need grooming? That seems like a way to reduce our labels, and not confuse contributors.

Thoughts @tjcran @misskniss ?

@jsjoeio
Copy link
Contributor

jsjoeio commented May 11, 2022

An external contributor won't know how to take action on this. Could we assume issues without labels need grooming?

I don't think we need to worry about that. There is no expectation that they would take action on that. They wouldn't be able to regardless.

We use the "triage" label on code-server and it serves the same purpose.

jsjoeio
jsjoeio approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense! Plus we can easily change this if needed later.

@bpmct
Copy link
Member Author

bpmct commented May 11, 2022 •
edited
Loading

I see - will merge once @misskniss takes a look

@kylecarbs
Copy link
Member

Ahh fair enough @jsjoeio !

@bpmct bpmct merged commit 537897c into main May 11, 2022
@bpmct bpmct deleted the bpmct/issue-template-grooming branch May 11, 2022 19:35
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@bpmct @kylecarbs
chore: add "needs grooming" label to new issues (#1384)
aefcbce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs left review comments

@jsjoeio jsjoeio jsjoeio approved these changes

@misskniss misskniss Awaiting requested review from misskniss

Assignees

@bpmct bpmct

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
4 participants
@bpmct @jsjoeio @kylecarbs @misskniss