Skip to content

feat: Unify cli behavior for templates create and update #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2022
Merged

feat: Unify cli behavior for templates create and update #1385

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4318133
feat: Unify cli behavior for templates create and update
mafredri May 11, 2022
1640e3b
Clean up pretty path with filepath.Clean
mafredri May 11, 2022
6bfed73
Clean up tests, amend PR comments
mafredri May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean up pretty path with filepath.Clean
  • Loading branch information
@mafredri
mafredri committed May 11, 2022
commit 1640e3bed35ec8d639d9b63eaf8fed47934ff946
3 changes: 2 additions & 1 deletion cli/templatecreate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,9 @@ func createValidTemplateVersion(cmd *cobra.Command, client *codersdk.Client, org

// prettyDirectoryPath returns a prettified path when inside the users
// home directory. Falls back to dir if the users home directory cannot
// discerned.
// discerned. This function calls filepath.Clean on the result.
func prettyDirectoryPath(dir string) string {
dir = filepath.Clean(dir)
homeDir, err := os.UserHomeDir()
if err != nil {
return dir
Expand Down