Skip to content

fix(site): enable dormant workspace to be deleted #13850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2024
Merged

fix(site): enable dormant workspace to be deleted #13850

merged 3 commits into from
Jul 9, 2024

Conversation

BrunoQuaresma
Copy link
Collaborator

Close #13786

@BrunoQuaresma BrunoQuaresma requested review from sreya and a team July 9, 2024 13:56
@BrunoQuaresma BrunoQuaresma self-assigned this Jul 9, 2024
@BrunoQuaresma BrunoQuaresma requested review from aslilac and removed request for a team July 9, 2024 13:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

🚀 Deploying PR 13850 ...

@BrunoQuaresma
Copy link
Collaborator Author

BrunoQuaresma commented Jul 9, 2024 •
edited
Loading

@stirby @aslilac @sreya, this is a minor change, but I would appreciate your extra pair of eyes to ensure that it does not break any other actions in the workspace UI, such as allowing unwanted options to be enabled in the "More options" menu.

@BrunoQuaresma
Copy link
Collaborator Author

PS: Unfortunately, the PR preview action is not working properly 😢. We will need to QA it locally for now.

aslilac
aslilac approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@BrunoQuaresma BrunoQuaresma merged commit 01b30ea into main Jul 9, 2024
@BrunoQuaresma BrunoQuaresma deleted the bq/enable-options-to-dormant branch July 9, 2024 17:55
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aslilac aslilac aslilac approved these changes

@sreya sreya Awaiting requested review from sreya

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No way to delete a dormant Workspace from within workspace page
2 participants
@BrunoQuaresma @aslilac