chore: return organization's display name and icon in templates #13858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0ssel
approved these changes
Jul 10, 2024
| LEFT JOIN | ||
| visible_users | ||
| ON | ||
| templates.created_by = visible_users.id |
There was a problem hiding this comment.
Is it possible that the created_by user is not visible by the caller of this? I'm thinking the case where someone is removed from an org after creating a template.
There was a problem hiding this comment.
It is, but we decided awhile back that if you can read the template, you should also see who created it. So granting read permission on the template gives some implicit permission to reading the user's name + organization information.
45bbfca to
8cae3e3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.