fix: remove license warning for customers #13865
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Jul 10, 2024
coadler
reviewed
Jul 10, 2024
| @@ -87,7 +87,7 @@ func Entitlements( | |||
| if isTrial { | |||
| showWarningDays = 7 | |||
| } | |||
| isExpiringSoon := daysToExpire > 0 && daysToExpire < showWarningDays | |||
| isExpiringSoon := isTrial && daysToExpire > 0 && daysToExpire < showWarningDays | |||
There was a problem hiding this comment.
This is probably dangerous since it won't show to admins if the license is expiring
There was a problem hiding this comment.
@coadler even admins of non-trial licensed deployments?
There was a problem hiding this comment.
Correct. The change should probably just be made on the CLI to only display if you're an admin.
There was a problem hiding this comment.
@coadler i'm not sure how to build this into the CLI. can you take this on?
There was a problem hiding this comment.
Would probably be best to make an issue and prioritize into a sprint, I don't have the cycles currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR removes the license warning for customers - this will only apply to trial licenses.
current state: