chore: assign user to multiple orgs in coderdtest user create #13867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
commented
Jul 10, 2024
| third := coderdtest.CreateOrganization(t, client, coderdtest.CreateOrganizationOptions{}) | ||
|
|
||
| // Assign the user to 3 orgs in this 1 statement | ||
| _, user := coderdtest.CreateAnotherUser(t, client, owner.OrganizationID, rbac.ScopedRoleOrgMember(second.ID), rbac.ScopedRoleOrgMember(third.ID)) |
There was a problem hiding this comment.
This is the result of this change. This line creates a new user and assigns them to 3 organizations. Much easier than doing this manually.
Emyrk
commented
Jul 10, 2024
| Log: api.Logger, | ||
| Request: r, | ||
| Action: database.AuditActionCreate, | ||
| OrganizationID: organization.ID, |
There was a problem hiding this comment.
Noticed these org ID's were missing in the audit logs
f0ssel
approved these changes
Jul 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateAnotherUsercan now assign users to multiple orgs. As I write multi-org tests, this is super useful to reduce LoC.