Skip to content

chore: add coder version to network telemetry events #13871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2024
Merged

chore: add coder version to network telemetry events #13871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51fcf83
chore: add coder version to network telemetry events
ethanndickson Jul 11, 2024
90132a9
fix pb, version -> clientversion
ethanndickson Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions coderd/telemetry/telemetry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1174,14 +1174,11 @@ type Netcheck struct {

PreferredDERP int64 `json:"preferred_derp"`

RegionLatency map[int64]time.Duration `json:"region_latency"`
RegionV4Latency map[int64]time.Duration `json:"region_v4_latency"`
RegionV6Latency map[int64]time.Duration `json:"region_v6_latency"`

GlobalV4 NetcheckIP `json:"global_v4"`
GlobalV6 NetcheckIP `json:"global_v6"`

CaptivePortal *bool `json:"captive_portal"`
}

func protoBool(b *wrapperspb.BoolValue) *bool {
Expand Down Expand Up @@ -1237,6 +1234,7 @@ type NetworkEvent struct {
Status string `json:"status"` // connected, disconnected
DisconnectionReason string `json:"disconnection_reason"`
ClientType string `json:"client_type"` // cli, agent, coderd, wsproxy
ClientVersion string `json:"client_version"`
NodeIDSelf uint64 `json:"node_id_self"`
NodeIDRemote uint64 `json:"node_id_remote"`
P2PEndpoint NetworkEventP2PEndpoint `json:"p2p_endpoint"`
Expand Down
176 changes: 93 additions & 83 deletions tailnet/proto/tailnet.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions tailnet/proto/tailnet.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ message TelemetryEvent {
Status status = 4;
string disconnection_reason = 5;
ClientType client_type = 6;
string client_version = 19;
uint64 node_id_self = 7;
uint64 node_id_remote = 8;
P2PEndpoint p2p_endpoint = 9;
Expand Down
Loading
Loading