Skip to content

feat(cli): pause notifications #13873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 11, 2024
Merged

feat(cli): pause notifications #13873

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
fc12d54
feat(cli): pause notifications
mtojek Jul 11, 2024
3777e94
stub
mtojek Jul 11, 2024
acab552
cli tests
mtojek Jul 11, 2024
4cfdc08
make gen
mtojek Jul 11, 2024
85179b3
golden
mtojek Jul 11, 2024
9e94fef
1.25
mtojek Jul 11, 2024
3694fae
unpause -> resume
mtojek Jul 11, 2024
d907ef2
check error message
mtojek Jul 11, 2024
94987d2
table tests
mtojek Jul 11, 2024
c8d208a
rm golden
mtojek Jul 11, 2024
727620d
missing colon
mtojek Jul 11, 2024
54404fa
linter complains
mtojek Jul 11, 2024
6c1e2d8
fix golden
mtojek Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
linter complains
  • Loading branch information
@mtojek
mtojek committed Jul 11, 2024
commit 54404fa07ab9dd3e7df28d0252cc594b65f6ec9f
1 change: 1 addition & 0 deletions cli/notifications_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ func TestNotifications(t *testing.T) {
}

for _, tt := range tests {
tt := tt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note for the future: this is not necessary as of Go 1.22 🎉

t.Run(tt.name, func(t *testing.T) {
t.Parallel()

Expand Down