feat: notify owner about failed autobuild #13891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderd/database/migrations/000226_notifications_autobuild_failed.up.sql
Outdated
Show resolved
Hide resolved
Comment on lines
+1730
to
+1782
| ignoreLogErrors := true | ||
| srv, db, ps, pd := setup(t, ignoreLogErrors, &overrides{ | ||
| notificationEnqueuer: notifEnq, | ||
| }) | ||
|
|
||
| user := dbgen.User(t, db, database.User{}) | ||
| initiator := user | ||
|
|
||
| template := dbgen.Template(t, db, database.Template{ | ||
| Name: "template", | ||
| Provisioner: database.ProvisionerTypeEcho, | ||
| OrganizationID: pd.OrganizationID, | ||
| }) | ||
| template, err := db.GetTemplateByID(ctx, template.ID) | ||
| require.NoError(t, err) | ||
| file := dbgen.File(t, db, database.File{CreatedBy: user.ID}) | ||
| workspace := dbgen.Workspace(t, db, database.Workspace{ | ||
| TemplateID: template.ID, | ||
| OwnerID: user.ID, | ||
| OrganizationID: pd.OrganizationID, | ||
| }) | ||
| version := dbgen.TemplateVersion(t, db, database.TemplateVersion{ | ||
| OrganizationID: pd.OrganizationID, | ||
| TemplateID: uuid.NullUUID{ | ||
| UUID: template.ID, | ||
| Valid: true, | ||
| }, | ||
| JobID: uuid.New(), | ||
| }) | ||
| build := dbgen.WorkspaceBuild(t, db, database.WorkspaceBuild{ | ||
| WorkspaceID: workspace.ID, | ||
| TemplateVersionID: version.ID, | ||
| InitiatorID: initiator.ID, | ||
| Transition: database.WorkspaceTransitionDelete, | ||
| Reason: tc.buildReason, | ||
| }) | ||
| job := dbgen.ProvisionerJob(t, db, ps, database.ProvisionerJob{ | ||
| FileID: file.ID, | ||
| Type: database.ProvisionerJobTypeWorkspaceBuild, | ||
| Input: must(json.Marshal(provisionerdserver.WorkspaceProvisionJob{ | ||
| WorkspaceBuildID: build.ID, | ||
| })), | ||
| OrganizationID: pd.OrganizationID, | ||
| }) | ||
| _, err = db.AcquireProvisionerJob(ctx, database.AcquireProvisionerJobParams{ | ||
| OrganizationID: pd.OrganizationID, | ||
| WorkerID: uuid.NullUUID{ | ||
| UUID: pd.ID, | ||
| Valid: true, | ||
| }, | ||
| Types: []database.ProvisionerType{database.ProvisionerTypeEcho}, | ||
| }) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
Nit: all the common bits here could be moved out to a helper func.
There was a problem hiding this comment.
Yeah, my problem with this idea is that we already have setup() function, so we will add another, let's say prepare(), but prepare() would be used only by 2/10 tests in the unit.
I think I will pass on it.
dannykopping
approved these changes
Jul 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: coder/internal#7
This PR implements a new notification: workspace autobuild failure.
Changes:
Workspace Autobuild FailedinitiatedBywithinitiatorinitiatorwhen autobuild deletes a workspace