Skip to content

fix: change audit descriptions to indicate unsuccessful attempts #13897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Jul 15, 2024

fixes #11607

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

@spikecurtis spikecurtis marked this pull request as ready for review July 15, 2024 20:31
@spikecurtis spikecurtis force-pushed the spike/11607-audit-unsuccessful branch 2 times, most recently from 98fc11d to a9aa60d Compare July 16, 2024 16:45
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote a whole thing about how I'm not crazy about ignoring all of the errors in here, but then I went to look up WriteString to see what errors it could return (I assumed allocation errors) only to see that the docs guarantee that it will only ever return nil. I find this frustrating, because our linting that requires the _, _ = makes it look like you're tossing tons of errors, but the docs explicitly say that you're not if you look them up.

maybe we could leave a comment that it'll never actually return an error despite the return type, to avoid confusion in the future. not a huge deal, I just wanted to flag the emotional journey this just sent me on. 😅

@spikecurtis spikecurtis force-pushed the spike/11607-audit-unsuccessful branch from a9aa60d to c925fad Compare July 16, 2024 18:38
@spikecurtis
Copy link
Contributor Author

I appreciate the detailed review that you took the time to check WriteString docs. Sorry for winding you up about error checking!

@spikecurtis spikecurtis merged commit 1f24ace into main Jul 16, 2024
28 checks passed
Copy link
Contributor Author

Merge activity

@spikecurtis spikecurtis deleted the spike/11607-audit-unsuccessful branch July 16, 2024 18:47
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed attempts to delete users show up in audit log as successful
2 participants