make lint / make gen

Signed-off-by: Danny Kopping <danny@coder.com>
coder · dannykopping · Jul 19, 2024 · Jul 12, 2024 · Jul 15, 2024 · Jul 16, 2024
commit 01d4f2f4d743bd0914f0d1257946448ef9f50eec
diff --git a/coderd/apidoc/docs.go b/coderd/apidoc/docs.go
diff --git a/coderd/apidoc/swagger.json b/coderd/apidoc/swagger.json
diff --git a/coderd/notifications/dispatch/smtp.go b/coderd/notifications/dispatch/smtp.go
@@ -327,8 +327,8 @@ func (s *SMTPHandler) client(ctx context.Context, host string, port string) (*sm
 	}
 
 	// Align with context deadline.
-	c.CommandTimeout = deadline.Sub(time.Now())
-	c.SubmissionTimeout = deadline.Sub(time.Now())
+	c.CommandTimeout = time.Until(deadline)
+	c.SubmissionTimeout = time.Until(deadline)
 
 	return c, nil
 }
@@ -360,7 +360,8 @@ func (s *SMTPHandler) tlsConfig() (*tls.Config, error) {
 	}
 
 	return &tls.Config{
-		ServerName:         srvName,
+		ServerName: srvName,
+		// nolint:gosec // Users may choose to enable this.
 		InsecureSkipVerify: s.cfg.TLS.InsecureSkipVerify.Value(),
 
 		RootCAs:      ca,
@@ -371,6 +372,7 @@ func (s *SMTPHandler) tlsConfig() (*tls.Config, error) {
 
 func (s *SMTPHandler) loadCAFile() (*x509.CertPool, error) {
 	if s.cfg.TLS.CAFile == "" {
+		// nolint:nilnil // A nil CertPool is a valid response.
 		return nil, nil
 	}
 
@@ -389,6 +391,7 @@ func (s *SMTPHandler) loadCAFile() (*x509.CertPool, error) {
 
 func (s *SMTPHandler) loadCertificate() (*tls.Certificate, error) {
 	if len(s.cfg.TLS.CertFile) == 0 && len(s.cfg.TLS.KeyFile) == 0 {
+		// nolint:nilnil // A nil certificate is a valid response.
 		return nil, nil
 	}
 

diff --git a/coderd/notifications/dispatch/smtp_test.go b/coderd/notifications/dispatch/smtp_test.go
@@ -372,6 +372,7 @@ func TestSMTP(t *testing.T) {
 		},
 	}
 
+	// nolint:paralleltest // Reinitialization is not required as of Go v1.22.
 	for _, tc := range tests {
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()

diff --git a/coderd/notifications/dispatch/smtp_util_test.go b/coderd/notifications/dispatch/smtp_util_test.go
@@ -152,11 +152,13 @@ func (s *Session) Data(r io.Reader) error {
 	return nil
 }
 
-func (s *Session) Reset() {}
+func (*Session) Reset() {}
 
-func (s *Session) Logout() error { return nil }
+func (*Session) Logout() error { return nil }
 
+// nolint:revive // Yes, useTLS is a control flag.
 func createMockSMTPServer(be *Backend, useTLS bool) (*smtp.Server, net.Listener, error) {
+	// nolint:gosec
 	tlsCfg := &tls.Config{
 		GetCertificate: readCert,
 	}

diff --git a/docs/api/schemas.md b/docs/api/schemas.md