Skip to content

fix: fix heartbeat select to prevent leak #13909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix: fix heartbeat select to prevent leak #13909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: fix heartbeat select to prevent leak
  • Loading branch information
@spikecurtis
spikecurtis committed Jul 16, 2024
commit fd8b0b879413e9252c25cf15cc5e8d99a789f1fa
3 changes: 1 addition & 2 deletions coderd/provisionerdserver/provisionerdserver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,7 @@ func TestHeartbeat(t *testing.T) {
select {
case <-hbCtx.Done():
return hbCtx.Err()
default:
heartbeatChan <- struct{}{}
case heartbeatChan <- struct{}{}:
return nil
}
}
Expand Down