Skip to content

chore: move notiffake to testutil #13933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2024
Merged

chore: move notiffake to testutil #13933

merged 1 commit into from
Jul 18, 2024

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jul 18, 2024

Related: coder/internal#7

@mtojek mtojek self-assigned this Jul 18, 2024
@mtojek mtojek added the hotfix label Jul 18, 2024
@mtojek mtojek marked this pull request as ready for review July 18, 2024 13:34
cdr-bot[bot]
cdr-bot bot approved these changes Jul 18, 2024
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@mtojek mtojek enabled auto-merge (squash) July 18, 2024 13:34
@mtojek mtojek merged commit 91cbe67 into main Jul 18, 2024
32 checks passed
@mtojek mtojek deleted the 7-testutil-notif branch July 18, 2024 13:36
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mtojek