Skip to content

chore: switch to generated types #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 12, 2022
Merged

chore: switch to generated types #1394

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f5d1b62
Add missing return when template version is not found
code-asher May 11, 2022
80a5d1a
Make template ID optional in create template version request
code-asher May 11, 2022
10bb649
Use generated types in test helper entities
code-asher May 11, 2022
d5eb87f
Make column renderer use the same type as its key
code-asher May 11, 2022
60323d8
Switch fully to generated types
code-asher May 11, 2022
609e6a2
Delete handwritten types
code-asher May 11, 2022
1de1986
Remove implemented omitempty as a future idea
code-asher May 11, 2022
04cc479
Revert "Add missing return when template version is not found"
code-asher May 11, 2022
22de907
Merge remote-tracking branch 'origin/main' into asher/generated-types
code-asher May 11, 2022
f8f6125
Add missing optionalities to generated request interfaces
code-asher May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove implemented omitempty as a future idea 
This was implemented in 2d3dc43.
  • Loading branch information
@code-asher
code-asher committed May 11, 2022
commit 1de19868180ad7ca53418d6c6befd090ef5261fb
3 changes: 1 addition & 2 deletions scripts/apitypings/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ This main.go generates typescript types from the codersdk types in Go.
# Features

- Supports Go types
- [x] Basics (string/int/etc)
- [x] Basics (string/int/etc)
- [x] Maps
- [x] Slices
- [x] Enums
Expand Down Expand Up @@ -36,5 +36,4 @@ type InternalType struct {

# Future Ideas

- Should `omitempty` in the `json` tag indicate optional?
- Use a yaml config for overriding certain types