chore: add webhook tests for notification subsystem #13942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
506a7e9 to
07b4a69
Compare
mafredri
approved these changes
Jul 19, 2024
| expectSuccess: false, | ||
| expectRetryable: true, | ||
| expectErr: "non-2xx response (500)", | ||
| }, |
There was a problem hiding this comment.
Perhaps we could add a test that sends bad data (wrong format) too, just to have the case covered?
There was a problem hiding this comment.
It's not actually possible, the webhook dispatch sends a well-formed request.
See func (w *WebhookHandler) dispatch
Signed-off-by: Danny Kopping <danny@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes coder/internal#5