Skip to content

fix: test: do not block Prometheus port #13945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2024
Merged

fix: test: do not block Prometheus port #13945

merged 2 commits into from
Jul 19, 2024

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jul 19, 2024

Fixes: #13931

@mtojek mtojek self-assigned this Jul 19, 2024
@mtojek mtojek marked this pull request as ready for review July 19, 2024 12:51
@mtojek mtojek marked this pull request as draft July 19, 2024 12:51
@mtojek mtojek changed the title fix: test: does not listen on Prometheus port fix: test: do not listen on Prometheus port Jul 19, 2024
@mtojek mtojek changed the title fix: test: do not listen on Prometheus port fix: test: do not block Prometheus port Jul 19, 2024
@mtojek mtojek marked this pull request as ready for review July 19, 2024 14:08
@mtojek mtojek requested a review from dannykopping July 19, 2024 14:08
dannykopping
dannykopping approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtojek mtojek merged commit 40609c2 into main Jul 19, 2024
29 checks passed
@mtojek mtojek deleted the 13931-prom-port branch July 19, 2024 14:29
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dannykopping dannykopping dannykopping approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: TestProvisionerDaemon_SessionToken/PrometheusEnabled
2 participants
@mtojek @dannykopping