Skip to content

chore: only add Meticulous recorder when running in dev mode #13950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2024
Merged

chore: only add Meticulous recorder when running in dev mode #13950

merged 2 commits into from
Jul 19, 2024

Conversation

alexivanov
Copy link
Contributor

Local sessions via the go server contain server-side rendered data and thus sessions cannot be simulated by Meticulous

@alexivanov
Only add Meticulous recorder when running in dev mode
a9f1c45 
Local sessions via the go server contain server-side rendered
data and such sessions cannot be simulated by Meticulous
@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Jul 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 19, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@alexivanov alexivanov changed the title Only add Meticulous recorder when running in dev mode chore: Only add Meticulous recorder when running in dev mode Jul 19, 2024
@coadler coadler requested a review from sreya July 19, 2024 15:53
@alexivanov alexivanov changed the title chore: Only add Meticulous recorder when running in dev mode chore: only add Meticulous recorder when running in dev mode Jul 19, 2024
@alexivanov
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@alexivanov
Copy link
Contributor Author

recheck

cdrcommunity added a commit to coder/cla that referenced this pull request Jul 19, 2024
@cdrcommunity
@alexivanov has signed the CLA in coder/coder#13950
03596f2
@sreya sreya merged commit dba2387 into coder:main Jul 19, 2024
29 of 33 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
@alexivanov alexivanov deleted the meticulous-recorder-dev-only branch July 25, 2024 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sreya sreya sreya approved these changes

Assignees

@alexivanov alexivanov

Labels
community Pull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexivanov @sreya