Skip to content

feat: get org scoped provisioners #13953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 23, 2024
Merged

feat: get org scoped provisioners #13953

merged 8 commits into from
Jul 23, 2024

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Jul 19, 2024

What this changes:

  • GET /organizations/{organization}/provisionerdaemons to require a valid organization and only return provisioners daemons from the specified organization
    • Even though this endpoint previously didn't validate the organization passed to it we have historically still called it with a proper org or "default".
  • Scope the provisioner daemon RBAC object to an organization - This expands the authorization to manage provisioner daemons from just template admins to now include org admins as well.

@f0ssel f0ssel marked this pull request as ready for review July 22, 2024 16:32
@f0ssel f0ssel requested a review from Emyrk July 22, 2024 16:32
@f0ssel f0ssel mentioned this pull request Jul 19, 2024
17 tasks
@f0ssel f0ssel enabled auto-merge (squash) July 23, 2024 14:44
@f0ssel f0ssel merged commit 0a07c7e into main Jul 23, 2024
29 checks passed
@f0ssel f0ssel deleted the f0ssel/get-org-provisioners branch July 23, 2024 14:56
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants