Skip to content

chore: keep active users active in scim #13955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 19, 2024
Merged

chore: keep active users active in scim #13955

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f618f35
chore: scim should keep active users active
Emyrk Jul 19, 2024
ef4c4d4
chore: add a unit test to excercise dormancy bug
Emyrk Jul 19, 2024
1b6036d
lint'
Emyrk Jul 19, 2024
ca1241b
audit log should not be dropped when there is no change
Emyrk Jul 19, 2024
5ffc829
add ability to cancel audit log
Emyrk Jul 19, 2024
806c284
add cancellable audit log v2
Emyrk Jul 19, 2024
73c9928
Add some comments
Emyrk Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add some comments
  • Loading branch information
@Emyrk
Emyrk committed Jul 19, 2024
commit 73c9928c77dee06a6c5f7cf3e9cab3e11f4fbf90
3 changes: 3 additions & 0 deletions coderd/audit/request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,10 +274,13 @@ func InitRequestWithCancel[T Auditable](w http.ResponseWriter, p *RequestParams)
req, commitF := InitRequest[T](w, p)
cancelled := false
return req, func(commit bool) {
// Once 'commit=false' is called, block
// any future commit attempts.
if !commit {
cancelled = true
return
}
// If it was ever cancelled, block any commits
if !cancelled {
commitF()
}
Expand Down
Loading