Skip to content

Remove coder templates edit command #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2022
Merged

Remove coder templates edit command #1396

merged 1 commit into from
May 11, 2022

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented May 11, 2022

Fixes #345

@f0ssel f0ssel requested a review from kylecarbs May 11, 2022 19:56
@codecov
Copy link

codecov bot commented May 11, 2022 •
edited
Loading

Codecov Report

Merging #1396 (81ecc53) into main (537897c) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1396      +/-   ##
==========================================
- Coverage   66.94%   66.93%   -0.01%     
==========================================
  Files         288      283       -5     
  Lines       18857    18650     -207     
  Branches      241      241              
==========================================
- Hits        12623    12484     -139     
+ Misses       4942     4893      -49     
+ Partials     1292     1273      -19
Flag Coverage Δ
unittest-go-macos-latest 54.08% <ø> (-0.01%) ⬇️
unittest-go-postgres- 65.50% <ø> (+0.11%) ⬆️
unittest-go-ubuntu-latest 56.41% <ø> (+0.01%) ⬆️
unittest-go-windows-2022 ?
unittest-js 74.24% <ø> (ø)
Impacted Files Coverage Δ
cli/templates.go 100.00% <ø> (ø)
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
peerbroker/dial.go 77.04% <0.00%> (-6.56%) ⬇️
cli/configssh.go 62.58% <0.00%> (-6.48%) ⬇️
pty/ptytest/ptytest.go 86.95% <0.00%> (-4.35%) ⬇️
cli/templateinit.go 58.62% <0.00%> (-3.45%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (-2.41%) ⬇️
peer/channel.go 84.21% <0.00%> (-2.34%) ⬇️
agent/agent.go 64.66% <0.00%> (-1.24%) ⬇️
cli/server.go 56.62% <0.00%> (-0.87%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 537897c...81ecc53. Read the comment docs.

@f0ssel f0ssel enabled auto-merge (squash) May 11, 2022 20:01
@f0ssel f0ssel merged commit be3bc5c into main May 11, 2022
@f0ssel f0ssel deleted the f0ssel/remove-template-edit branch May 11, 2022 20:05
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@f0ssel @kylecarbs
Remove coder templates edit command (#1396)
62188a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

coder templates edit has no clear purpose
3 participants
@f0ssel @kylecarbs @misskniss